[scripts] Adding `run_tests.sh` script by rparolin · Pull Request #953 · NVIDIA/cuda-python

rparolin · 2025-09-08T22:09:58Z

[scripts] Adding run_tests.sh script

The run_tests.sh script runs all the nested cuda_python modules unit tests and reports back a unified status.

copy-pr-bot · 2025-09-08T22:10:01Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

rparolin · 2025-09-08T23:45:45Z

/ok to test 99646dd

leofang · 2025-09-09T01:28:40Z

Ralf is probably the main user of the toolshed scripts, so let me request his review

cuda_core/README.md

toolshed/run_all_tests.sh

cpcloud · 2025-09-09T16:57:17Z

toolshed/run_all_tests.sh

+
+Options:
+  -v, --verbose       Verbose pytest output (-ra -s -v)
+      --install       Force editable install with [test] extras


This seems a bit out of scope for a script that runs tests. Personally I would be surprised if a script called run_test_all started installing stuff and assumed that pip install -e . is a thing from wherever I ran it.

Installing dependencies seems like a separate concern from running tests.

Yeah, I was on the fence about this but I was wanting this to be "one stop shop" script that handles everything a user would need when running from a clean branch.

toolshed/run_all_tests.sh

…. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # Date: Tue Sep 9 15:07:24 2025 -0700 # # On branch rparolin/run_test_all # Your branch is up to date with 'origin/rparolin/run_test_all'. # # Changes to be committed: # new file: conftest.py # new file: pytest.ini # modified: scripts/run_tests.sh # modified: tests/integration/test_smoke.py #

… into rparolin/run_test_all

rparolin · 2025-09-09T22:30:06Z

/ok test ed3236a

tests/integration/test_smoke.py

conftest.py

cuda_pathfinder/tests/conftest.py

rparolin · 2025-09-10T18:58:48Z

/ok to test 8b5ae53

rparolin · 2025-09-15T23:57:52Z

/ok to test 6c32a0b

…sabled flag: CUDA_PYTHON_CUDA_PER_THREAD_DEFAULT_STREAM

rparolin · 2025-09-16T06:01:55Z

/ok to test 4dd2fac

rparolin · 2025-09-16T15:12:17Z

@cpcloud @rwgk Please re-review, if this is ready to submit to main.

rwgk

I didn't review run_tests.sh in detail, but I'll try it out as soon as this PR is merged!

cuda_core/README.md

rparolin · 2025-09-16T17:32:02Z

/ok to test 846c5c7

rparolin · 2025-09-16T17:45:23Z

@rwgk Sorry to trouble you again for another review. Its making me get the PR re-approved after I made your requested change.

github-actions · 2025-09-16T20:28:12Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

rwgk · 2025-09-16T20:48:02Z

@rwgk Sorry to trouble you again for another review. Its making me get the PR re-approved after I made your requested change.

Sorry I missed this before! Great to see this merged.

rparolin · 2025-09-16T23:12:17Z

Thanks everyone! 👍 🚀

cuda_pathfinder/tests/conftest.py

rparolin added 2 commits September 8, 2025 13:56

Adding script that runs all nested modules unit tests.

ed3236a

updating legal

99646dd

rparolin requested a review from leofang September 8, 2025 22:20

rparolin marked this pull request as ready for review September 8, 2025 22:22

This comment has been minimized.

Sign in to view

leofang requested a review from rwgk September 9, 2025 01:28

Merge branch 'main' into rparolin/run_test_all

1dc7cc4

rwgk reviewed Sep 9, 2025

View reviewed changes

cuda_core/README.md Show resolved Hide resolved

toolshed/run_all_tests.sh Show resolved Hide resolved

leofang requested a review from cryos September 9, 2025 16:39

cpcloud reviewed Sep 9, 2025

View reviewed changes

toolshed/run_all_tests.sh Show resolved Hide resolved

renaming run_all_tests.sh to run_tests.sh

ae1deba

rparolin changed the title ~~[toolshed] Adding run_test_all.sh script~~ [scripts] Adding run_test_all.sh script Sep 9, 2025

rparolin changed the title ~~[scripts] Adding run_test_all.sh script~~ [scripts] Adding run_tests.sh script Sep 9, 2025

rparolin added 6 commits September 9, 2025 13:57

removing unnecessary file print

94e362f

Removing unnecessary prints

421ca99

Using pytest.mark

e777b66

Merge branch 'main' into rparolin/run_test_all

b3c761a

Merge branch 'rparolin/run_test_all' of github.com:NVIDIA/cuda-python…

275009c

… into rparolin/run_test_all

leofang assigned rparolin Sep 10, 2025

leofang added P2 Low priority - Nice to have test Improvements or additions to tests cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module cuda.pathfinder Everything related to the cuda.pathfinder module labels Sep 10, 2025

cpcloud reviewed Sep 10, 2025

View reviewed changes

tests/integration/test_smoke.py Outdated Show resolved Hide resolved

cpcloud reviewed Sep 10, 2025

View reviewed changes

tests/integration/test_smoke.py Outdated Show resolved Hide resolved

cpcloud reviewed Sep 10, 2025

View reviewed changes

conftest.py Show resolved Hide resolved

cpcloud reviewed Sep 10, 2025

View reviewed changes

cuda_pathfinder/tests/conftest.py Outdated Show resolved Hide resolved

rparolin added 2 commits September 10, 2025 09:13

Removing empty function

141881d

Removing integration test placeholder

8b5ae53

NVIDIA deleted a comment from copy-pr-bot bot Sep 10, 2025

Merge branch 'main' into rparolin/run_test_all

6c32a0b

rparolin added 2 commits September 15, 2025 17:45

docs: changing to

0833013

Running examples and also running cuda_bindings tests both enabled/di…

4dd2fac

…sabled flag: CUDA_PYTHON_CUDA_PER_THREAD_DEFAULT_STREAM

rwgk previously approved these changes Sep 16, 2025

View reviewed changes

cuda_core/README.md Outdated Show resolved Hide resolved

run_all_tests.sh → run_tests.sh (3x)

846c5c7

rparolin dismissed rwgk’s stale review via 846c5c7 September 16, 2025 17:31

rparolin enabled auto-merge (squash) September 16, 2025 17:32

cryos approved these changes Sep 16, 2025

View reviewed changes

rparolin merged commit 4bc9941 into main Sep 16, 2025
49 checks passed

rparolin deleted the rparolin/run_test_all branch September 16, 2025 20:13

rwgk reviewed Sep 17, 2025

View reviewed changes

cuda_pathfinder/tests/conftest.py Show resolved Hide resolved

rwgk mentioned this pull request Sep 17, 2025

Fail if no "INFO test_" lines are found in pathfinder test output #979

Merged

Conversation

rparolin commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

copy-pr-bot bot commented Sep 8, 2025

Uh oh!

rparolin commented Sep 8, 2025

Uh oh!

This comment has been minimized.

leofang commented Sep 9, 2025

Uh oh!

Uh oh!

Uh oh!

cpcloud Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

rparolin Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rparolin commented Sep 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rparolin commented Sep 10, 2025

Uh oh!

rparolin commented Sep 15, 2025

Uh oh!

rparolin commented Sep 16, 2025

Uh oh!

rparolin commented Sep 16, 2025

Uh oh!

rwgk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rparolin commented Sep 16, 2025

Uh oh!

rparolin commented Sep 16, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

rwgk commented Sep 16, 2025

Uh oh!

rparolin commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rparolin commented Sep 8, 2025 •

edited

Loading